Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(req). Disable deep linking for specific pages and defaultHistory should accept params #11411

Closed
sfaizanh opened this issue Apr 27, 2017 · 6 comments

Comments

@sfaizanh
Copy link

Ionic version:
[ ] 1.x
[ ] 2.x
[x] 3.x

[x] feature request

IonicPage doesn't contain any property to disable deep so when universal linking is enabled this page should not be accessible.

@IonicPage({disabled: true})
@Component({page: 'setting-page'})
@IonicPage({defaultHistory: ['Home', 'user/:id'] })
@Component({page: 'details-page'})

localhost:8100/#/user/2/details

@jgw96
Copy link
Contributor

jgw96 commented Apr 27, 2017

Hello! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

@jgw96 jgw96 closed this as completed Apr 27, 2017
@jgw96
Copy link
Contributor

jgw96 commented Apr 27, 2017

This issue was moved to driftyco/ionic-feature-requests#191

@sfaizanh
Copy link
Author

Appreciated! 👍

@WhatsThatItsPat
Copy link

@sfaizanh
Copy link
Author

@PatrickMcD yeah same thing but i was thinking a bit more if we want object to pass then?

@IonicPage({defaultHistory: [{segment: 'Home', data: {} }, { segment: 'user/:id', data: {id: 2} }] })
@Component({page: 'details-page'})

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants