Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab-icon-left breaks with tab-bar #1093

Closed
mhartington opened this issue Apr 9, 2014 · 4 comments
Closed

Tab-icon-left breaks with tab-bar #1093

mhartington opened this issue Apr 9, 2014 · 4 comments
Assignees
Milestone

Comments

@mhartington
Copy link
Contributor

Combining tab-bar with a card-based layout with tabs (similar to facebook) breaks the alignment of the card tab icon and title

More on the forum
http://forum.ionicframework.com/t/tab-icon-left-css-broken/2785/5

Codepen
http://codepen.io/mhartington/pen/cKsaD?editors=100

@ajoslin
Copy link
Contributor

ajoslin commented Apr 9, 2014

@adamdbradley Looked into this a bit, it's because the .tabs-icon-bottom .tab-item rule on a tabbar inherits forever, into the content of the tabbar. This is because of the recent change where we allowed the tabs-icon-bottom class on the parent of the .tabs element itself.

Possible fix from my look at it: Change it to .tabs-icon-bottom > .tabs .tab-item

@adamdbradley
Copy link
Contributor

Fixed. Thanks @ajoslin for looking into it, that worked perfectly, thanks.

@adamdbradley adamdbradley added this to the 1.0.0-beta.2 milestone Apr 18, 2014
@akralj
Copy link

akralj commented Jul 17, 2014

Hi
I'm sorry to say that this is still not resolved. Please have a look again at @mhartington codepen, which uses ionic-nightly:
http://codepen.io/mhartington/pen/cKsaD?editors=100
The last version of ionic.css where it is working is beta 1.
Problem also shows in the example in the docs:
http://ionicframework.com/docs/components/#icon-left-tabs
thank you for this great framework
andrej

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants