modal.shown and modal.hidden $emit doesn't pass modal anymore

[jprichardson]

This commit b593cf1#diff-252c9b347a8b59e14b893043061f4309R45 broke my code.

This was changed:

this.scope.$parent.$broadcast('modal.hidden', this);

to

this.scope.$parent.$broadcast('modal.hidden');

and

self.scope.$parent.$broadcast('modal.removed', self);

to

self.scope.$parent.$broadcast('modal.removed');

was this intentional? My goal is to be able to call code when the modal is visible from within the modal controller. My old way was a bit hacky, as I was listening for modal.shown using $on.

[jprichardson]

Line 44 & 45 (new commit) shows the modal.shown change.

[ajoslin]

Hm, I guess I removed it because it was undocumented and I didn't find it as a necessity. But you're right, it's really good to have. Adding it back.

[jprichardson]

Awesome, thank you! Does it make sense to pass the modal on modal.removed?

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.