diff --git a/angular/BREAKING.md b/angular/BREAKING.md index 611a15205fb..7d058276b6a 100644 --- a/angular/BREAKING.md +++ b/angular/BREAKING.md @@ -42,6 +42,7 @@ A list of the breaking changes introduced to each component in Ionic Angular v4. - [Overlays](#overlays) - [Radio](#radio) - [Range](#range) +- [Refresher](#refresher) - [Segment](#segment) - [Select](#select) - [Spinner](#spinner) @@ -1041,6 +1042,27 @@ These have been renamed to the following: ``` +## Refresher + +The `enabled` property (with a default value of `true`) has been renamed to `disabled` (with a default value of `false`). + +**Old Usage Example:** + +```html + + ... + +``` + +**New Usage Example:** + +```html + + ... + +``` + + ## Segment The markup hasn't changed for Segments, but now writing `` will render a native button element inside of it. diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 14cc37250dd..62e394e66ad 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -5443,7 +5443,7 @@ declare global { */ 'complete': () => void; /** - * If true, the refresher will be hidden. Defaults to `true`. + * If true, the refresher will be hidden. Defaults to `false`. */ 'disabled': boolean; /** @@ -5489,7 +5489,7 @@ declare global { */ 'closeDuration'?: string; /** - * If true, the refresher will be hidden. Defaults to `true`. + * If true, the refresher will be hidden. Defaults to `false`. */ 'disabled'?: boolean; /** diff --git a/core/src/components/refresher/refresher.tsx b/core/src/components/refresher/refresher.tsx index 94753a80449..0801e30d401 100644 --- a/core/src/components/refresher/refresher.tsx +++ b/core/src/components/refresher/refresher.tsx @@ -71,9 +71,9 @@ export class Refresher { @Prop() snapbackDuration = '280ms'; /** - * If true, the refresher will be hidden. Defaults to `true`. + * If true, the refresher will be hidden. Defaults to `false`. */ - @Prop() disabled = true; + @Prop() disabled = false; /** * Emitted when the user lets go of the content and has pulled down diff --git a/core/src/components/refresher/test/basic/index.html b/core/src/components/refresher/test/basic/index.html index 9031fb68877..e1bda44d20e 100644 --- a/core/src/components/refresher/test/basic/index.html +++ b/core/src/components/refresher/test/basic/index.html @@ -11,8 +11,6 @@ - - Pull To Refresh @@ -20,21 +18,18 @@ - + - - - -