Skip to content

Commit 6baf005

Browse files
authored
feat(angular): remove IonBackButtonDelegate (#29030)
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We currently export two versions of the `ion-back-button` angular implementation: `IonBackButton` and `IonBackButtonDelegate`. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removes `IonBackButtonDelegate` in favor of `IonBackButton` ## Does this introduce a breaking change? - [x] Yes - [ ] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> - The `IonBackButtonDelegate` class has been removed in favor of `IonBackButton`. ```diff - import { IonBackButtonDelegate } from '@ionic/angular'; + import { IonBackButton } from '@ionic/angular'; ``` ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent 1fb8ff7 commit 6baf005

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

BREAKING.md

+14-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ This is a comprehensive list of the breaking changes introduced in the major ver
2929
- [Select](#version-8x-select)
3030
- [Textarea](#version-8x-textarea)
3131
- [Toggle](#version-8x-toggle)
32+
- [Framework Specific](#version-8x-framework-specific)
33+
- [Angular](#version-8x-angular)
3234

3335
<h2 id="version-8x-browser-platform-support">Browser and Platform Support</h2>
3436

@@ -198,4 +200,15 @@ For more information on styling toast buttons, refer to the [Toast Theming docum
198200

199201
<h4 id="version-8x-toggle">Toggle</h4>
200202

201-
- The `legacy` property and support for the legacy syntax, which involved placing an `ion-toggle` inside of an `ion-item` with an `ion-label`, have been removed. For more information on migrating from the legacy toggle syntax, refer to the [Toggle documentation](https://ionicframework.com/docs/api/toggle#migrating-from-legacy-toggle-syntax).
203+
- The `legacy` property and support for the legacy syntax, which involved placing an `ion-toggle` inside of an `ion-item` with an `ion-label`, have been removed. For more information on migrating from the legacy toggle syntax, refer to the [Toggle documentation](https://ionicframework.com/docs/api/toggle#migrating-from-legacy-toggle-syntax).
204+
205+
<h2 id="version-8x-framework-specific">Framework Specific</h2>
206+
207+
<h4 id="version-8x-angular">Angular</h4>
208+
209+
- The `IonBackButtonDelegate` class has been removed in favor of `IonBackButton`.
210+
211+
```diff
212+
- import { IonBackButtonDelegate } from '@ionic/angular';
213+
+ import { IonBackButton } from '@ionic/angular';
214+
```

packages/angular/src/index.ts

-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ export { SelectValueAccessorDirective as SelectValueAccessor } from './directive
55
export { TextValueAccessorDirective as TextValueAccessor } from './directives/control-value-accessors/text-value-accessor';
66
export { IonTabs } from './directives/navigation/ion-tabs';
77
export { IonBackButton } from './directives/navigation/ion-back-button';
8-
// TODO FW-5889
9-
export { IonBackButton as IonBackButtonDelegate } from './directives/navigation/ion-back-button';
108
export { IonNav } from './directives/navigation/ion-nav';
119
export { IonRouterOutlet } from './directives/navigation/ion-router-outlet';
1210
export {

0 commit comments

Comments
 (0)