From 41f54f8e2d20dd14faeb84bcc6c833ad6f7c8bff Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Tue, 20 Mar 2018 17:21:02 +0100 Subject: [PATCH] fix(angular): removeViewFromDom --- core/src/components/nav/view-controller.ts | 9 ++++++--- core/src/utils/index.ts | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/core/src/components/nav/view-controller.ts b/core/src/components/nav/view-controller.ts index 1aeda9f87d8..6ce9b28781b 100644 --- a/core/src/components/nav/view-controller.ts +++ b/core/src/components/nav/view-controller.ts @@ -47,7 +47,7 @@ export class ViewController { const component = this.component; if (this.delegate) { - return this.delegate.attachViewToDom(container, component, this.data, ['ion-page']).then(el => { + return this.delegate.attachViewToDom(container, component, this.data, ['ion-page', 'hide-page']).then(el => { this.element = el; }); } @@ -102,9 +102,12 @@ export class ViewController { const element = this.element; if (element) { - element.remove(); + if (this.delegate) { + this.delegate.removeViewFromDom(element.parentElement, element); + } else { + element.remove(); + } } - this._nav = this._cntDir = this._leavingOpts = null; this._state = ViewState.Destroyed; } diff --git a/core/src/utils/index.ts b/core/src/utils/index.ts index 8da1bcb91c3..e5ce6951fe3 100644 --- a/core/src/utils/index.ts +++ b/core/src/utils/index.ts @@ -1,2 +1,3 @@ export * from './haptic'; export * from './keyboard'; +export * from './transition';