Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build ionic v1 project (since ionic v4 update) #3406

Closed
jacquesdev opened this issue Jul 26, 2018 · 10 comments
Closed

Can't build ionic v1 project (since ionic v4 update) #3406

jacquesdev opened this issue Jul 26, 2018 · 10 comments
Labels

Comments

@jacquesdev
Copy link

Description:
I can't build my ionic v1 app

Steps to Reproduce:


**Output:**

ionic-v1 build
[ERROR] Command not found: ionic-v1



**My `ionic info`:**
<!--
Post the output of running `ionic info` (within your project, if applicable)
below. `ionic info` is a CLI command that prints out environment information.
-->

Ionic:

ionic (Ionic CLI) : 4.0.1
Ionic Framework : ionic1 1.3.5
@ionic/v1-toolkit : not installed

Cordova:

cordova (Cordova CLI) : 7.1.0
Cordova Platforms : ios 4.5.4

System:

ios-deploy : 1.9.2
NodeJS : v8.9.4 (/Users/user/.nvm/versions/node/v8.9.4/bin/node)
npm : 2.15.12
OS : macOS High Sierra
Xcode : Xcode 9.4 Build version 9F1027a

Environment:

ANDROID_HOME : /Library/Android/sdk



**Other Information:**
:(
@ionitron-bot ionitron-bot bot added the triage label Jul 26, 2018
@jacquesdev
Copy link
Author

I guess this is because the new project @ionic/v1-toolkit is required, perhaps you can update the error to mention this?

@imhoffd imhoffd added bug project type: ionic1 Ionic 1 projects and removed triage labels Jul 26, 2018
@imhoffd
Copy link
Contributor

imhoffd commented Jul 26, 2018

Thanks @jacquesdev

Yep, it's a bad error message.

@dave-k
Copy link

dave-k commented Jul 31, 2018

$ ionic cordova build ios
ionic-v1 build
[ERROR] Command not found: ionic-v1

I am getting the same error.
What is the fix for this error?

@imhoffd
Copy link
Contributor

imhoffd commented Aug 1, 2018

npm i -D @ionic/v1-toolkit

I am working on an auto-installer prompt at this moment.

@parthnayak7448
Copy link

After using

npm i -D @ionic/v1-toolkit

i was successfully able to build my ionic v1 app in ionic CLI 4.0.2

thanks @dwieeb

@dave-k
Copy link

dave-k commented Aug 1, 2018

There is an issue with node and the 'internal contextify script' : Assertion `args[1]->IsString()' failed

macOS High Sierra v10.13.5

$ npm -v
6.2.0
$ node -v
v10.7.0
$ ionic -v
CLI 4.0.2

$ ionic cordova build ios
> ionic-v1 build
ionic-v1[53011]: ../src/node_contextify.cc:635:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed.

@imhoffd
Copy link
Contributor

imhoffd commented Aug 1, 2018

@dave-k That looks like a different issue. Please create a new issue.

@rodrigograca31
Copy link

I had version 4.0.0 (updated the moment it came out) and had that bad error message.
I've run sudo npm i -g ionic@latest and re run my build command and got:

> ionic-v1 build

[INFO] Looks like @ionic/v1-toolkit isn't installed in this project.
       
       This package is required for this command to work properly.

? Install @ionic/v1-toolkit? Yes
> npm i -D -E @ionic/v1-toolkit

AWESOME!

P.S. shouldnt it use --save? (so that it works in the future....)

@imhoffd
Copy link
Contributor

imhoffd commented Aug 3, 2018

@rodrigograca31 Good to hear the prompt is working for you. --save has been the default in npm for a while now! It should automatically save it to package.json.

@rodrigograca31
Copy link

Oh, didn't know that! Yes, it saved! (under devDependencies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants