Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

fix(sass sourcemaps): output valid source maps, that chrome can parse #306

Merged
merged 8 commits into from
Jan 28, 2017

Conversation

flobacher
Copy link
Contributor

Short description of what this resolves:

#46
sourcemaps for sass are broken

Changes proposed in this pull request:

Fixes: #
output the full sourcemap, not only the mappings-property

@flobacher
Copy link
Contributor Author

please merge, so scss sourcemaps would work again. they are still broken @ionic/app-scripts v 0.0.43

@danbucholtz danbucholtz merged commit 6589550 into ionic-team:master Jan 28, 2017
@danbucholtz
Copy link
Contributor

@flobacher,

Thanks!

Thanks,
Dan

@gianpaj
Copy link

gianpaj commented Feb 8, 2017

Thanks for this.

I'm trying this on Ionic App Scripts Version: 1.0.1 but doesn't seem to work.

I'm using ionic serve and they're not being interpreted - if there at all.

I tried this as well ionic serve --nobrowser --generateSourceMap (they should be on by default, as per readme docs), but nothing.

I don't see any .map file being generated for example on this url:
http://localhost:8100/build/main.css.map

or any inline source maps the end of main.css

Info:

$ ionic info

Your system information:

Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.1
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.9
Ionic App Scripts Version: 1.0.1
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: OS X El Capitan
Node Version: v6.9.4
Xcode version: Xcode 8.2.1 Build version 8C1002

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants