feat(): change http-server to use request hostname instead of the con…

…figured hostname.
ionic-team · Mar 14, 2017 · 8e1e81a · 8e1e81a
1 parent 3001190
commit 8e1e81a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/dev-server/http-server.ts b/src/dev-server/http-server.ts
@@ -82,7 +82,7 @@ function serveIndex(req: express.Request, res: express.Response)  {
   const indexFileName = path.join(config.wwwDir, process.env[Constants.ENV_VAR_HTML_TO_SERVE]);
   fs.readFile(indexFileName, (err, indexHtml) => {
     if (config.useLiveReload) {
-      indexHtml = injectLiveReloadScript(indexHtml, config.host, config.liveReloadPort);
+      indexHtml = injectLiveReloadScript(indexHtml, req.hostname, config.liveReloadPort);
     }
 
     indexHtml = injectNotificationScript(config.rootDir, indexHtml, config.notifyOnConsoleLog, config.notificationPort);

diff --git a/src/dev-server/live-reload.ts b/src/dev-server/live-reload.ts
@@ -53,9 +53,6 @@ export function injectLiveReloadScript(content: any, host: string, port: Number)
 }
 
 function getLiveReloadScript(host: string, port: Number) {
-  if (host === '0.0.0.0') {
-    host = 'localhost';
-  }
   var src = `//${host}:${port}/livereload.js?snipver=1`;
   return `  <!-- Ionic Dev Server: Injected LiveReload Script -->\n  <script src="${src}" async="" defer=""></script>`;
 }