Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): change proxy url generation #7354

Merged
merged 4 commits into from
Mar 20, 2024
Merged

fix(http): change proxy url generation #7354

merged 4 commits into from
Mar 20, 2024

Conversation

jcesarmobile
Copy link
Member

On iOS >= 17.2, the proxyUrl.protocol = bridgeUrl.protocol; is not changing the protocol of the proxy url.
Change the proxyUrl generation to return the bridgeUrl, which already has the capacitor protocol and add the other relevant proxyUrl parameters and modified pathname.

closes #7352

Copy link
Member

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the project linked in the ticket, and doesn't break the test app - not sure how else to put it though it's paces, but looks good.

@jcesarmobile jcesarmobile merged commit 318c316 into main Mar 20, 2024
6 checks passed
@jcesarmobile jcesarmobile deleted the RDMR-73 branch March 20, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: capacitor native http interceptor breaking requests
3 participants