fix(cli): adjust SPM parameters for build and run commands #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markemer
requested review from
jcesarmobile,
theproducer,
nflsilva,
giralte-ionic and
andredestro
giralte-ionic
approved these changes
Mar 14, 2024
jcesarmobile
changed the title
jcesarmobile
requested changes
Mar 15, 2024
There was a problem hiding this comment.
the only thing that changes is the -workspace/-project and the actual project path, so the package manager check should just set those two params and keep a single xcodebuild call on build and a single xcodebuildArgs, as that would make the change smaller and the code easier to maintain, like in example the recently added configuration for run command if it would have done after this, it would require changing both xcodebuildArgs arrays.
|
That's a good point, I'll change that. |
|
I was literally removing them as you posted that. 😄 |
jcesarmobile
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.