Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): set port for proxy url #7341

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix(http): set port for proxy url #7341

merged 2 commits into from
Mar 14, 2024

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Mar 13, 2024 •
edited
Loading

Despite host includes both hostname and port, setting the host to an url without port doesn't remove the existing port if there is one, turning the proxy url into an invalid one.
So set the hostname and port separately to match the capacitor bridge url hostname/port

@jcesarmobile jcesarmobile merged commit a3059dc into main Mar 14, 2024
6 checks passed
@jcesarmobile jcesarmobile deleted the set-port branch March 14, 2024 12:35
jcesarmobile added a commit that referenced this pull request Mar 14, 2024
@jcesarmobile
fix(http): set port for proxy url (#7341)
de60caf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giralte-ionic giralte-ionic giralte-ionic approved these changes

@markemer markemer Awaiting requested review from markemer

@theproducer theproducer Awaiting requested review from theproducer

@nflsilva nflsilva Awaiting requested review from nflsilva

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcesarmobile @giralte-ionic