-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Signing with build command still not working in 6.0.0-rc.0? #7299
Comments
This issue needs more information before it can be addressed. In particular, the reporter needs to provide a minimal sample app that demonstrates the issue. If no sample app is provided within 15 days, the issue will be closed. |
Added repro. |
Have you tried this with 6.0.0-rc.1? Let me know if it's still broken. |
This issue has been labeled as |
I've tested on the provided app and it's still broken, looks like there was a typo when making the requested changes |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out. |
Capacitor Version
Latest Dependencies:
@capacitor/cli: 5.7.0
@capacitor/core: 5.7.0
@capacitor/android: 5.7.0
@capacitor/ios: 5.7.0
Installed Dependencies:
@capacitor/ios: not installed
@capacitor/cli: 6.0.0-rc.0
@capacitor/core: 5.7.0
@capacitor/android: 5.7.0
[success] Android looking great! 👌
Other API Details
Platforms Affected
Current Behavior
I ran into this issue #7054.
It was supposedly solved, so I upgraded the cli to 6.0.0-rc.0 but I was still getting an error:
I printed out the apksigner command run to try to run it myself but it also gave the same error. Eventually tried passing --key-pass the password with
pass:
(because unlike --ks-pass it was not added) and then it worked.So what seems to be happening is this line is not adding
pass:
.capacitor/cli/src/android/build.ts
Line 114 in fe53330
I can submit PR to fix, but also would it not be better to allow the user to specify this and somewhere in the documentation + CapacitorConfig types link to the apksigner docs? which allow more options than just
pass:
likeenv:
andfile:
which can be very useful. https://developer.android.com/tools/apksigner#:~:text=%2D%2Dkey%2Dpass%20%3Cinput%2Dformat%3EExpected Behavior
I would expect to be able to either pass the password without
pass
in both cases or better docs/error + enforcement ofpass/env/file:
prefix.Project Reproduction
Repo
Build web project, add android with capacitor, then try to do
npm run cap:build
. I added a script to be sure it uses the project's pinned 6.0.0 cli.Keystore is included with password 123456 for both passwords an key alias "key"`.
Additional Information
If anybody runs into this, as a workarround you can do something like this in the capacitor.config.ts:
The text was updated successfully, but these errors were encountered: