feat(ios): Replace usage of UserDefaults with KeyValueStore.

[Steven0351]

This will prevent every single Capacitor user from having to declare use of a required reason API when it becomes required by Apple. This is also made available for plugin authors or others who utilize Capacitor as a dependency.

[Steven0351]

Honestly not sure why I'm keying off the URL instead of just the name. That would allow for checking for its existence before doing all the other url logic.

[markemer]

We already talked about this a bunch, but it also works when I run it, so that's good.

[jcesarmobile]

This will break live updates for users using cordova-plugin-ionic, because the plugin is storing in UserDefaults the values being read by Capacitor, so if the plugin still uses UserDefaults but Capacitor don't read those values then the plugin will not work.
Do we plan to force users to use the new Capacitor live updates plugin with Capacitor 6 instead of cordova-plugin-ionic?
If not, this is not something we can merge.

[Steven0351]

This will break live updates for users using cordova-plugin-ionic, because the plugin is storing in UserDefaults the values being read by Capacitor, so if the plugin still uses UserDefaults but Capacitor don't read those values then the plugin will not work. Do we plan to force users to use the new Capacitor live updates plugin with Capacitor 6 instead of cordova-plugin-ionic? If not, this is not something we can merge.

cordova-plugin-ionic is not actually reading or setting any values being set by Capacitor core through UserDefaults in this case. For the serverBasePath stuff it actually goes through Ionic.WebView https://github.com/search?q=repo%3Aionic-team%2Fcordova-plugin-ionic+serverBasePath&type=code which should be routing to the Capacitor WebView plugin. All other use of UserDefaults in cordova-plugin-ionic is for its own data, which has no impact on core.

[jcesarmobile]

Ah, sorry, I was thinking about lastBinaryVersionCode and lastBinaryVersionName, not serverBasePath, but looks like they are not stored by cordova-plugin-ionic neither, it stores binaryVersionName and binaryVersionCode, without last prefix, so they are different things and we should be safe.

[Steven0351]

Ah, sorry, I was thinking about lastBinaryVersionCode and lastBinaryVersionName, not serverBasePath, but looks like they are not stored by cordova-plugin-ionic neither, it stores binaryVersionName and binaryVersionCode, without last prefix, so they are different things and we should be safe.

No worries, I immediately thought of cordova-plugin-ionic when I started this work and tried to be very thorough in my vetting of its uses.