fix(ios): Add Codable folder to podspec source_files #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
Steven0351,
markemer,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
markemer
approved these changes
Dec 14, 2023
giralte-ionic
approved these changes
Dec 14, 2023
Steven0351
reviewed
Dec 14, 2023
| @@ -16,8 +16,8 @@ Pod::Spec.new do |s| | |||
| s.ios.deployment_target = '13.0' | |||
| s.authors = { 'Ionic Team' => '[email protected]' } | |||
| s.source = { git: 'https://github.com/ionic-team/capacitor.git', tag: package['version'] } | |||
| s.source_files = "#{prefix}Capacitor/Capacitor/*.{swift,h,m}", "#{prefix}Capacitor/Capacitor/Plugins/*.{swift,h,m}", | |||
| "#{prefix}Capacitor/Capacitor/Plugins/**/*.{swift,h,m}" | |||
| s.source_files = "#{prefix}Capacitor/Capacitor/*.{swift,h,m}", "#{prefix}Capacitor/Capacitor/Codable/*.{swift,h,m}", | |||
There was a problem hiding this comment.
I know this is late, but why don't we just make this:
s.source_files = "#{prefix}Capacitor/Capacitor/**/*.{swift,h,m}"
This should recursively include all files under capacitor and we wouldn't have to keep adding this anytime we decide to add a folder for organization purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.