fix(android): make local urls use unpatched fetch #6953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
markemer
approved these changes
Oct 4, 2023
IT-MikeS
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the resource object to a Request object makes the url absolute, so all the resources are going through the patched fetch even if resource was a relative url before the conversion to Request.
Instead of checking if the url starts with http/https, as all are now, check if the url starts with the server url value, as if it starts with the server url value it should be a local request.
I'm adding a
/at the end of the server url so request to the same url but with a different port don't get intercepted.closes #6944