feat(cli): add apksigner as a build option

[yooouuri]

closes: #6284

[markemer]

Can you run npm run fmt - that should fix the lint failures.

[yooouuri]

Can you run npm run fmt - that should fix the lint failures.

Sure my bad

[yooouuri]

@markemer lint failures should be fixed now

[yooouuri]

@markemer node scripts/pack-cli-assets.mjs was failing, my latest commit fixed this

Edit: Also removed the keystorealias and keystorealiaspass build options, because they are not needed anymore

[IT-MikeS]

Looks like some lint errors still showing up. You may just need to run another fmt but you may need more work as well.

[yooouuri]

@IT-MikeS ran another npm run fmt

[yooouuri]

@markemer any success on checking my PR?

[markemer]

I got buy in, I think we just needed to wait for Cap5 to ship. Now I just need to get some reviews.

[markemer]

I think I want to add a fallback for people that still want to use jarsigner (as inadvisable as that may be) do you mind if I make changes to this branch? I'd like you to get credit for your contributions, so if you want me to work elsewhere, we can setup a branch on main to merge this into.

[yooouuri]

@markemer no problem, be my guest! Use this branch!

[markemer]

@markemer no problem, be my guest! Use this branch!

Cool - will do.

[liuwin7]

When will this feature be released.
Looking forward ...

[dfa1234]

Why this is still in review?
Android 11 was like 3 years ago...

[markemer]

Hey @yooouuri - I think I have this working right - you have to affirmatively pick apksigner - but next major release I'm going to flip that so apksigner is the default

[yooouuri]

@markemer LGTM

added signingtype: 'apksigner', to buildCommand function and it works fine!

Using the vite plugin I created

https://github.com/bistroo/vite-plugin-capacitor

import { defineConfig } from 'vite'

export default defineConfig({
  plugins: [
    viteCapacitorPlugin({
      buildOptions: {
        keystorepath: 'xxxxxxx',
        keystorepass: 'xxxxxxx',
        androidreleasetype: 'APK',
        signingtype: 'apksigner',
      },
    }),
  ],
})

[15aabruzzese]

Hey @markemer, @IT-MikeS, and @yooouuri can you guys give me an example of how this is used, I've been trying to get this to work without any luck. I've done the following in the pipeline and tried it locally, but only get the following:

I've tried both AAB and APK file types with no luck and always seems to trigger the jarsigner error.

Please help, thank you!

[markemer]

@15aabruzzese --signing-type apksigner is what you need to feed it, looks like you're feeding it --signing-type AAB

[15aabruzzese]

@markemer I tried both APK and AAB. Here is what I am trying to get working locally, I'm getting a incorrect password error but checked the following: console logged it in build.js file, checked that it worked to access the keystore, used both "",'', pass:"", and pass:''. Also I can sign through Android Studio

[liuwin7]

@markemer
I think you should try this feature again.

1. If run the build command without options in console by using the capacitor.config.ts file. the error will occur.

[error] Missing options. Please supply all options for android signing. (Keystore Path, Keystore Password, Keystore Key
        Alias, Keystore Key Password)

2. The command option --signing-type not work, because the third part lib, commander, transform the option name to signingType instead of signingtype.

    .addOption(
      new Option(
        '--signing-type <signingtype>',
        'Program used to sign apps (default: jarsigner)',
      ).choices(['apksigner', 'jarsigner']),
    )
    .action(
      wrapAction(
        telemetryAction(
@@ -168,6 +174,7 @@ export function runProgram(config: Config): void {
              keystorealias,
              keystorealiaspass,
              androidreleasetype,
              signingtype,

For the error, I created a new pull request. #6716

[trinitiwowka]

It's mistake, return pls))

[liuwin7]

Yeah, so I created a pull request to correct it, but still not merged yet. 😞