fix: copy url from nativeResponse to response in native-bridge.ts #6397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsChaceD
approved these changes
Mar 17, 2023
ItsChaceD
requested review from
IT-MikeS,
jcesarmobile,
markemer and
theproducer
wilgert
force-pushed
the
main
branch
3 times, most recently
from
73da9e9 to
43791a4
Compare
|
I now ran prettier :-) |
markemer
approved these changes
Mar 24, 2023
wilgert
force-pushed
the
main
branch
2 times, most recently
from
0052918 to
7ed2e0f
Compare
IT-MikeS
approved these changes
Mar 28, 2023
This url is used in `cordova-plugin-ionic` to do live updates. Without this fix the `response.url` would be an empty string here: https://github.com/ionic-team/cordova-plugin-ionic/blob/5b190675525806ea15e56d4e59eb67b74cc58c55/www/common.ts#L288 and live updates do not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This url is used in
cordova-plugin-ionicto do live updates. Without this fix theresponse.urlwould be an empty string here:https://github.com/ionic-team/cordova-plugin-ionic/blob/5b190675525806ea15e56d4e59eb67b74cc58c55/www/common.ts#L288
and live updates do not work.