-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iOS): properly handle date types during JSValue coercion #4043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just some minor changes. And please remove the unrelated whitespace diffs, if possible.
This reverts commit dbb72bf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The type bridging actually has a lot of test coverage (the exception in the project) so it'd be good to update the unit tests to verify the additional date handling. But that can be addressed in a separate branch.
This PR fixes a missing case in
coerceToJSValue
in which NSDate values were not being returned, resulting in nil values.Example: