Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for iOS target(s) #3993

Closed
imhoffd opened this issue Dec 27, 2020 · 6 comments · Fixed by #4073
Closed

Add configuration option for iOS target(s) #3993

imhoffd opened this issue Dec 27, 2020 · 6 comments · Fixed by #4073

Comments

@imhoffd
Copy link
Contributor

imhoffd commented Dec 27, 2020

We can add a configuration option which could use the configured target/scheme in sync and run.

@imhoffd imhoffd added this to the 3.0.0-rc milestone Dec 27, 2020
@MortenGregersen
Copy link
Contributor

This is not always so simple. We have 8 targets (variations) of the same app.

@imhoffd
Copy link
Contributor Author

imhoffd commented Dec 30, 2020

I think the best we can do is add a configuration option. When combined with capacitor.config.ts files (see https://capacitorjs.com/docs/v3/config), you can use an environment variable to switch targets.

@imhoffd imhoffd added enhancement and removed bug labels Dec 30, 2020
@imhoffd imhoffd changed the title Handle schemes other than "App" in run command Add configuration option for iOS target(s) Dec 30, 2020
@imhoffd
Copy link
Contributor Author

imhoffd commented Dec 31, 2020

@MortenGregersen Related: please see #4002 which moves public into the target directory. sync could use the configured target when copying web assets into place

@MortenGregersen
Copy link
Contributor

I think the best we can do is add a configuration option. When combined with capacitor.config.ts files (see https://capacitorjs.com/docs/v3/config), you can use an environment variable to switch targets.

Yes, with a dynamic config file this would work. This is awesome!

@MortenGregersen Related: please see #4002 which moves public into the target directory. sync could use the configured target when copying web assets into place

As I see it, the public directory is moved a level up. How does this relate to the configured target? @dwieeb

@imhoffd
Copy link
Contributor Author

imhoffd commented Jan 5, 2021

Yes, with a dynamic config file this would work. This is awesome!

Great to hear! 😊

After some investigation, the configuration option will likely be a scheme (aka Xcode build configuration), not a target. This is required for 'run' to invoke 'xcodebuild', and we can use it to discover the target, because every scheme has an associated target (usually by the same name).

How does this relate to the configured target?

Only in that it organizes the project folder a bit. Not entirely related.

@imhoffd imhoffd linked a pull request Jan 16, 2021 that will close this issue
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 11, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants