fix(iOS): Only open a URL while the application is active #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch avoids a bug discovered by an enterprise client. In the reproduction case, if a user performs a double tap on a
tellink, the application will get stuck in theinactivestate. When opening the URL, the system presents an action sheet so the user can confirm the dial operation. However, if a secondtelURL is attempted to open while that system-supplied action sheet is on-screen (and the application isinactive), the application will not be moved to theactivestate if the user selectscanceland dismisses the sheet. The application needs to be deactivated some other way (app switcher, etc) for the normal application life cycle events to be restored.Under normal operations, the application shouldn't be asking the system to open URLs if it is not active so I'm not aware of any issues with the added check.