Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Don't return 404 on empty files #3323

Merged
merged 1 commit into from
Jul 23, 2020
Merged

fix(android): Don't return 404 on empty files #3323

merged 1 commit into from
Jul 23, 2020

Conversation

jcesarmobile
Copy link
Member

If file is empty stream.available() returns 0, so make available return -1 when the stream is null to distinguish between empty and not found

closes #3312

asztal
asztal approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@asztal asztal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix - I figured it might be something like this, but didn't create a PR since I wasn't sure if it was correct 👍

@imhoffd imhoffd merged commit cfbd1e3 into ionic-team:2.x Jul 23, 2020
@imhoffd imhoffd deleted the empty-not-found branch July 23, 2020 18:25
@imhoffd imhoffd added this to the 2.3.1 milestone Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlpoole carlpoole carlpoole approved these changes

@imhoffd imhoffd imhoffd approved these changes

@asztal asztal asztal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jcesarmobile @asztal @imhoffd @carlpoole