Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): add deprecation notice for electron #3263

Merged
merged 1 commit into from
Jul 14, 2020
Merged

chore(cli): add deprecation notice for electron #3263

merged 1 commit into from
Jul 14, 2020

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Jul 14, 2020

No description provided.

@imhoffd imhoffd requested a review from IT-MikeS July 14, 2020 18:52
@imhoffd imhoffd added this to the 2.3.0 milestone Jul 14, 2020
IT-MikeS
IT-MikeS approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@IT-MikeS IT-MikeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, users can still use the old platform until 3.0+ but start pushing toward npx cap <command> @capacitor-community/electron feature of 2.3.X

@imhoffd
Copy link
Contributor Author

imhoffd commented Jul 14, 2020

Yeah, and for now I'm just linking to the repo because the installation instructions there will always remain current.

@imhoffd imhoffd merged commit b7d5639 into master Jul 14, 2020
@imhoffd imhoffd deleted the electron-warning branch July 14, 2020 21:43
@jcesarmobile jcesarmobile mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-MikeS IT-MikeS IT-MikeS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@imhoffd @IT-MikeS