chore(android): improve error message when Filesystem.copy fails #3148
Conversation
In my case, this failed on Android 10 due to not having permissions and not having `android:requestLegacyExternalStorage="true"` in `AndroidManifest.xml`. At least if there's a useful error message, it's a starting point for debugging (though perhaps this should be mentioned in the documentation somewhere, either for the FileSystem plugin or for Android configuration - or even for the default template, since the plugins need it to work?) https://commonsware.com/blog/2019/06/07/death-external-storage-end-saga.html
jcesarmobile
changed the title
jcesarmobile
changed the title
There was a problem hiding this comment.
Changes look good and work fine. I don't find the open failed: EACCES (Permission denied) particularly helpful, but it's better than unknown.
About the copying problems you mention, I had no problem copying a photo taken from Camera plugin to Data directory. Data, Cache and External should be safe to use in future Android releases as they belong to your app.
The folders that were restricted in Android 10 and that could go away in a future release are public folders like the ones used by Documents or ExternalStorage.
|
Hey @jcesarmobile! Does your comment quoted below mean that all we have to do to be able to safely remove
Also thanks for all your hard work on the repo...if I haven't supplied you with enough context to answer my question, just let me know and I'll fill it in ASAP 👍 |
In my case, this failed on Android 10 due to not having
android:requestLegacyExternalStorage="true"in
AndroidManifest.xml. At least if there's a useful error message, it's a starting point for debugging.I noticed the documentation for the FileSystem plugin does mention this for the FileSystemDirectory.Documents
enum member, but actually this can also be required when copying a file produced by the Camera plugin into the Data
directory.
Presumably this was introduced when upgrading the target SDK version from 28 to 29, so it might be worth calling
out in the 2.0 upgrade notes here.
I'm also a little concerned about what I read about Android 10+. If Capacitor doesn't switch to using the Storage Access Framework, will copying photos from the camera stop working entirely at some point?
https://commonsware.com/blog/2019/06/07/death-external-storage-end-saga.html