Update Gradle Wrapper to 5.6.4 #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friederbluemle
force-pushed
the
update-gradle-wrapper
branch
from
201ec78 to
bbc225f
Compare
|
Rebased onto latest |
friederbluemle
force-pushed
the
update-gradle-wrapper
branch
from
bbc225f to
1a48368
Compare
friederbluemle
force-pushed
the
update-gradle-wrapper
branch
from
1a48368 to
0607aec
Compare
|
Rebased onto latest master branch. |
imhoffd
approved these changes
Jun 22, 2020
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip |
There was a problem hiding this comment.
Do you know why we need the all distribution (with gradle source code) vs bin?
There was a problem hiding this comment.
As you mentioned, all includes additional sources that makes it easier to work with Gradle scripts. On top of that, it's the default distribution that is used by new projects generated with Android Studio, as well as new projects initialized with the React Native CLI. That makes it much more likely to already exist in the local cache on a developer's machine, saving an additional download.
|
Thank you @friederbluemle!! 🍻 This will make it into Capacitor 2.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully updates all 4 Gradle Wrappers contained in this repo to
5.6.4.As you can see in the diff, it does not actually change the
distributionUrlingradle-wrapper.properties(it was already set to5.6.4). However, according to the sha256sum of thegradle-wrapper.jarfiles, they had not been touched since Gradle 2.10 🤯 (initially added to this repo on Nov 19 2017 - 947aab2) The wrapper scripts (i.e.gradlew/gradlew.bat) were also missing many updates that went into newer releases of Gradle.With the changes here, all files associated with Gradle Wrapper are updated to match the version
5.6.4distribution of Gradle.