Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting MessageHandler #2510

Merged
merged 5 commits into from
Jun 24, 2020

Conversation

imjacobclark
Copy link
Contributor

@imjacobclark imjacobclark commented Mar 3, 2020

Second contribution 👋!

No functional changes here, I simplified the check if we're a cordovaPlugin, javascriptError or anything else.

I also extracted the predicates that checks if the types (null, cordova, js error) to help make the postMessage a little easier to read.

Replaced new Runnable with a Lambda and the // Only eval the JS code if this is a valid callback id comment with a clear variable name.

Moved both public methods to the top of the file and the private methods at the bottom.

@imhoffd
Copy link
Contributor

imhoffd commented Jun 23, 2020

@imjacobclark Would you mind resolving the conflicts and updating this PR?

@imjacobclark
Copy link
Contributor Author

@imjacobclark Would you mind resolving the conflicts and updating this PR?

@dwieeb yep, will fix this up tomorrow, thanks for taking a look!

@imjacobclark
Copy link
Contributor Author

@dwieeb conflicts sorted!

@imhoffd imhoffd requested a review from carlpoole June 24, 2020 02:24
Copy link
Member

@carlpoole carlpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had a question about one of the branches of the if statement

@imjacobclark
Copy link
Contributor Author

@carlpoole thanks, fixed the comment! What is the process to getting this merged?

@imhoffd imhoffd merged commit befe798 into ionic-team:master Jun 24, 2020
@imhoffd
Copy link
Contributor

imhoffd commented Jun 24, 2020

We just merge it. 😉

Thanks for your contribution, @imjacobclark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants