Test JSObject #2508
Test JSObject #2508
Conversation
android/capacitor/build.gradle
Outdated
| @@ -54,6 +54,9 @@ dependencies { | |||
| implementation 'com.google.firebase:firebase-messaging:18.0.0' | |||
| implementation 'com.google.android.gms:play-services-location:17.0.0' | |||
| testImplementation 'junit:junit:4.12' | |||
| testImplementation 'org.json:json:20140107' | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I'm not sure this is needed. The only import the test code has that uses this is import org.json.JSONException; and that's included in Android API.
There was a problem hiding this comment.
This is needed to prevent java.lang.RuntimeException: Method getString in org.json.JSONObject not mocked. See http://g.co/androidstudio/not-mocked for details. errors as JSON is bundled with Android and thus hitting a stub, so a real JSON implementation is needed to drive a real valuable test.
There was a problem hiding this comment.
OK, that explanation is fine with me.
android/capacitor/src/test/java/com/getcapacitor/JSObjectTest.java
Outdated
Show resolved
Hide resolved
|
@imjacobclark Any comment on the above review? Also, this repo uses GitHub Actions, would you be able to update the PR? |
Hey @dwieeb @smpeters thanks for the review - it’s on my todo list to fix this up, I’ll get around to it tomorrow I think! |
|
LGTM! Thanks for getting Capacitor set up with testing in Java. 😅 |
@dwieeb no problem! What’s the process to get this merged in? |
|
Couple things yet... @smpeters Would you care to comment further or resolve the conversation in your review? |
LGTM |
First contribution here...
I plan on contributing more than these tests in this PR, but I chose JSObject as a first good place to start.
Feedback/thoughts welcome!
Thanks