smalloc: cleanup & refactoring #920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Non-blocking comment: this seems to increase the number of round trips between JS and C++ for a given Alloc call; does moving the type checking logic to JS balance that out, perf-wise? |
|
(Otherwise this looks good to me pending @trevnorris' +1) |
|
ping @trevnorris |
| @@ -152,19 +166,9 @@ size_t ExternalArraySize(enum ExternalArrayType type) { | |||
| void CopyOnto(const FunctionCallbackInfo<Value>& args) { | |||
| Environment* env = Environment::GetCurrent(args); | |||
|
|
|||
| if (!args[0]->IsObject()) | |||
| return env->ThrowTypeError("source must be an object"); | |||
| if (!args[2]->IsObject()) | |||
There was a problem hiding this comment.
Mind switching these to ASSERT()? Useful for when we're calling these directly from core.
|
couple minor comments. LGTM otherwise. |
vkurchatkin
force-pushed
the
smalloc-cleanup
branch
from
69fb5f8
to
1b3d362
Compare
|
@trevnorris added asserts. PTAL |
|
@vkurchatkin LGTM. Great work. |
vkurchatkin
added a commit
that referenced
this pull request
Mar 4, 2015
PR-URL: #920 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
vkurchatkin
added a commit
that referenced
this pull request
Mar 4, 2015
PR-URL: #920 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@trevnorris