Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #1476

Closed
wants to merge 6 commits into from
Closed

doc: update AUTHORS list #1476

wants to merge 6 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 20, 2015

Update AUTHORS list using tools/update-authors.sh

chrisdickinson and others added 4 commits April 17, 2015 14:52
This commit:
  - fixes development branch (v1.x -> master)
  - updates stability index wording
  - use iojs binary instead of node

PR-URL: nodejs#1466
Reviewed-By: Ben Noordhuis <[email protected]>
This reverts commit 06cfff9.

Reverted because it introduced a regression where (because options were
modified in the later functionality) options.host and options.port would
be overridden with values provided in other, supported ways.

PR-URL: nodejs#1467
Reviewed-By: Ben Noordhuis <[email protected]>
This commit adds a test to ensure all options are NOT modified after
passing them to http.request. Specifically options.host and options.port
are the most prominent that would previously error, but add the other
options that have default values.

options.host and options.port were overridden for the one-argument
net.createConnection(options) call.

PR-URL: nodejs#1467
Reviewed-By: Ben Noordhuis <[email protected]>
@rvagg
Copy link
Member Author

rvagg commented Apr 20, 2015

unsure if I should PR against v1.x or master

@bnoordhuis
Copy link
Member

LGTM and I'm not sure either.

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Apr 20, 2015
@Fishrock123
Copy link
Contributor

Shouldn't it PR against what it was generated from?

it should be 1.x until 1.8.1 ships, then split, I think?

@chrisdickinson
Copy link
Contributor

Anything you want in both v1.8.1 and v2.0.0 should go in v1.x for the time being. Once v1.8.1 is released I will merge v1.8.1 back into v2.0.0.

chrisdickinson and others added 2 commits April 20, 2015 20:25
This brings in the '%PYTHON%' revert, and restores
the correct NODE_MODULE_VERSION.

PR-URL: nodejs#1482
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Update AUTHORS list using tools/update-authors.sh

PR-URL: nodejs#1476
Reviewed-By: Ben Noordhuis <[email protected]>
@rvagg
Copy link
Member Author

rvagg commented Apr 21, 2015

landed @ 2632775 on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants