-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose v1.8.1 #1460
Propose v1.8.1 #1460
Conversation
Are we sure we need to revert OpenSSL? Plus, if we can avoid reverting it, it is a good QoL change due to performance. Also, is there no way to fix the build for the %PYTHON% thing? libuv builds fine with it.. |
Tests are running here. Updated to remove the openssl reverts. |
can we merge everything but the build commit so we can at least try out builds? otherwise we can't even get windows nightlies |
@rvagg I don't think there should be any problem with that. |
you can remove 94aa91e, it's already in as 53ed89d Nightly ran OK with that commit in, results are @ https://iojs.org/download/nightly/v1.8.1-nightly2015042053ed89d927/ please test this if you can ppl! |
@Fishrock123 the problem isn't %python% but the quotes surrounding it. No real win fixing that though since gyp hardcodes python anyway. |
Note that the nightly isn't exactly perfect, since it has the |
Cool, updated this PR to omit the revert commit. If everything checks out we should be able to cut a v1.8.1 release today. |
I'm a little unsure about overwriting the 1.8.0 changelog. Last time @rvagg just made a new 1.7.1 entry. |
Notable Changes: * build: revert vcbuild.bat changes * changes inherited from v1.8.0: * build: Support for building io.js as a static library (Marat Abdullin) #1341 * npm: Upgrade npm to 2.8.3. (Forrest L Norvell) #1448 * deps: upgrade openssl to 1.0.2a (Shigeki Ohtsu) #1389 * src: allow multiple arguments to be passed to process.nextTick (Trevor Norris) #1077 * module: the interaction of require('.') with NODE_PATH has been restored and deprecated. This functionality will be removed at a later point. (Roman Reiss) #1363
@Fishrock123 Ah, I omitted v1.8.0 in the CL per @rvagg's comment here. |
Fair enough. |
Waiting on a LGTM before continuing. cc @iojs/tc |
LGTM |
:makeitso: |
PR-URL: #1460 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Merged in 7b7da2e. |
This is a fast follow up to #1436.
This reverts the problematic build changes,
and the openssl changes (to be merged later, into master)(edit: openssl is okay after all), and includes the release commit and changelog.