Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose v1.8.1 #1460

Closed
wants to merge 2 commits into from
Closed

Propose v1.8.1 #1460

wants to merge 2 commits into from

Conversation

chrisdickinson
Copy link
Contributor

This is a fast follow up to #1436.

This reverts the problematic build changes, and the openssl changes (to be merged later, into master) (edit: openssl is okay after all), and includes the release commit and changelog.

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Apr 18, 2015
@Fishrock123
Copy link
Contributor

Are we sure we need to revert OpenSSL?

#1436 (comment)

Plus, if we can avoid reverting it, it is a good QoL change due to performance.

Also, is there no way to fix the build for the %PYTHON% thing? libuv builds fine with it..

@chrisdickinson
Copy link
Contributor Author

Tests are running here.

Updated to remove the openssl reverts.

@rvagg
Copy link
Member

rvagg commented Apr 20, 2015

can we merge everything but the build commit so we can at least try out builds? otherwise we can't even get windows nightlies

@chrisdickinson
Copy link
Contributor Author

@rvagg I don't think there should be any problem with that.

@rvagg
Copy link
Member

rvagg commented Apr 20, 2015

you can remove 94aa91e, it's already in as 53ed89d

Nightly ran OK with that commit in, results are @ https://iojs.org/download/nightly/v1.8.1-nightly2015042053ed89d927/ please test this if you can ppl!

@jbergstroem
Copy link
Member

@Fishrock123 the problem isn't %python% but the quotes surrounding it. No real win fixing that though since gyp hardcodes python anyway.

@Fishrock123
Copy link
Contributor

Note that the nightly isn't exactly perfect, since it has the NODE_MODULE_VERSION bump still.

@chrisdickinson
Copy link
Contributor Author

Cool, updated this PR to omit the revert commit. If everything checks out we should be able to cut a v1.8.1 release today.

@Fishrock123
Copy link
Contributor

I'm a little unsure about overwriting the 1.8.0 changelog. Last time @rvagg just made a new 1.7.1 entry.

Notable Changes:

* build: revert vcbuild.bat changes
* changes inherited from v1.8.0:
  * build: Support for building io.js as a static
    library (Marat Abdullin) #1341
  * npm: Upgrade npm to 2.8.3. (Forrest L Norvell) #1448
  * deps: upgrade openssl to 1.0.2a (Shigeki Ohtsu) #1389
  * src: allow multiple arguments to be passed to
    process.nextTick (Trevor Norris) #1077
  * module: the interaction of require('.') with NODE_PATH has been
    restored and deprecated. This functionality will be removed at
    a later point. (Roman Reiss) #1363
@chrisdickinson
Copy link
Contributor Author

@Fishrock123 Ah, I omitted v1.8.0 in the CL per @rvagg's comment here.

@Fishrock123
Copy link
Contributor

Fair enough.

@chrisdickinson
Copy link
Contributor Author

Waiting on a LGTM before continuing. cc @iojs/tc

@Fishrock123
Copy link
Contributor

LGTM

@rvagg
Copy link
Member

rvagg commented Apr 20, 2015

:makeitso:

chrisdickinson added a commit that referenced this pull request Apr 20, 2015
PR-URL: #1460
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@chrisdickinson
Copy link
Contributor Author

Merged in 7b7da2e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants