-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: don't check wrk when testing non-http benchmark #1368
Conversation
@@ -121,7 +120,7 @@ Benchmark.prototype.http = function(p, args, cb) { | |||
|
|||
if (code) { | |||
console.error('wrk failed with ' + code); | |||
process.exit(code) | |||
process.exit(code); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, not sure if we care about style here or not but I'd revert this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted.
LGTM otherwise |
Also, @JacksonTian I'm assuming it may be intentional, but the email you use with git isn't registered to you on github, so the commits don't show up under your user. :) |
it doesn't matter. That my company email. 发自我的 iPhone
|
when testing non-http benchmark, no need the wrk tool. so move the wrk check into http method.
When running a non-http benchmark, there is no need the check for the wrk tool so move the wrk check into the http method. PR-URL: #1368 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Cheers @JacksonTian, landed in d2b62a4. |
when testing non-http benchmark, no need the wrk tool.
so move the wrk check into http method.