Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #1342 #1349

Closed
wants to merge 1 commit into from
Closed

Revert #1342 #1349

wants to merge 1 commit into from

Conversation

Gioyik
Copy link
Contributor

@Gioyik Gioyik commented Apr 5, 2015

See discussion here: #1342

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Apr 5, 2015
@mscdex
Copy link
Contributor

mscdex commented Apr 5, 2015

The first line of the commit message should be prefixed with doc:

EDIT: actually I suppose something like this would be better: Revert "doc: fix typo in CHANGELOG.md" with a link to the commit on the proceeding commit message lines.

Fishrock123 pushed a commit that referenced this pull request Apr 5, 2015
@Gioyik @Fishrock123
Revert "doc: fix typo in CHANGELOG.md"
48d69cf 
This reverts commit bde2b3e.

PR-URL: #1349
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Fishrock123
Copy link
Contributor

_sigh_

Landed 48d69cf - thanks.

@Fishrock123 Fishrock123 closed this Apr 5, 2015
@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 5, 2015

Thanks for the comments @mscdex and thanks for the merge @Fishrock123

@Fishrock123 Fishrock123 mentioned this pull request Apr 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gioyik @mscdex @Fishrock123