Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add GPG fingerprint for Fishrock123 #1324

Merged
merged 2 commits into from
Apr 4, 2015
Merged

doc: add GPG fingerprint for Fishrock123 #1324

merged 2 commits into from
Apr 4, 2015

Conversation

Fishrock123
Copy link
Contributor

See #1225

Also includes better formatting for gpg key fingerprints in the readme.

R=@rvagg

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Apr 2, 2015
@benjamingr
Copy link
Member

Awesome :) Good luck with releases.

@Fishrock123
Copy link
Contributor Author

Also, my GPG keyprint is publicly verifiable here: https://keybase.io/fishrock

@bnoordhuis
Copy link
Member

Did you upload your public key to sks-keyservers.net? It doesn't appear to be visible yet. At least, I can't find it.

@Fishrock123
Copy link
Contributor Author

@bnoordhuis went to upload.. chrome gives me a security error due to this:

screen shot 2015-04-02 at 5 11 11 pm

I mean it's just the pubkey, but still.

@bnoordhuis
Copy link
Member

Ah, it's using a certificate that's signed by a self-signed CA... why are we recommending sks-keyservers.net again?

@Fishrock123
Copy link
Contributor Author

Also, my GPG keyprint is publicly verifiable here: https://keybase.io/fishrock

Well, again, my key and info is publicly verifiable and searchable on keybase.

It looks like a lot of node-related people are on there too.

@bnoordhuis
Copy link
Member

Yeah, no reason to let that hold up this PR. LGTM.

@rvagg
Copy link
Member

rvagg commented Apr 3, 2015

the https error is because that hostname resolves to a pool of hosts which identify as their own hostname. We are recommending sks-keyservers because it's a reliable way to get the key into the biggest GPG key pool, there are other hosts you can submit to and they'll end up in the same place I think but this is as good as any, minus the https problem

@rvagg
Copy link
Member

rvagg commented Apr 3, 2015

addendum: the key has to be in that key pool before we can push forward with this, there are a number of automated download/install scripts out there, including https://github.com/iojs/docker-iojs/blob/6355158c25e37cce11847466eb11aee198540bed/1.6/Dockerfile#L4 that rely on this to work, keybase isn't helpful here

@Fishrock123
Copy link
Contributor Author

I uploaded this to the keyserver, but can't find it in the search; can someone verify?

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org

mQINBFM7JpoBEACmf7uB5P5QJ8X38ARQn+dr+/O+6/wzkKzUcoFvRArwZTcpdEO/
0C12kNSpK2UkVMh4sorYwA8W0yv3spZJWU3TiIfCVryxqZaAWEIU+dwsQ0P6EAUy
thjdQEs81bG6aN0dUqE26fWjGL/mU7BPtAwfzg6lty2cwZJP5zaNCl/PjRUeTKC2
oNas3M5dWoOqWq6HLPqnTEPHPlZ/mhkOfLOnJA6r669sQcml5R+Lhwd8wdJp+ANi
DLW661MmaiA4VqjEXwsXKK0KISWftEgd9WGBsHH8rn4KdKj9u6EtnDlA3vaPmADZ
mf7RVSMRoMkdiswFqEIMQuhTVbqS69vyhtByQs1fhriYrPy3OMeSMjJ/zNDCnHTB
uKxoNHgMcznVu1tjz+ggso7Whd0IiXEaHXhF5ASWnJJa+xLxXQRQV2X1RXEK0bAy
SX5B+NmxJRVY+ixpO5TVhQhzzzL9Ivz4z0odlvt5VJJIHHFIAWkgXRNAo0wgDzfe
+jHOE7nz9uzYsqDBV25Zo22oMZURTBN87WZ1TFpDiORvvjR8QXJIBIUvMHAhG/Zl
EkVopoNaznUOplnr/ToDpA1RDrdxeUAQ1i99EeBtXRREFgByFvETnVCkX/pvQA1y
FrhGFgqCYBpN4IK0UcUx1MuwPBrfZxbL/cy+FhmJqutB6ufaJzatMQHu5QARAQAB
tClrZXliYXNlLmlvL2Zpc2hyb2NrIDxmaXNocm9ja0BrZXliYXNlLmlvPokCPQQT
AQoAJwUCUzsmmgIbLwUJEswDAAULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRAJ
/kRzTreZDoJsD/4vYyw9IchMrrJiWiKNuk1u8JTeIHNa5ONwFOFl65Wq9pwm1t8H
eTKubKmTwqpjoRsV3QlT9GNW10rp0kJ5hlmlkcaPx/q4VmDksCAhp3NyQI0p0h53
YBzwZKssNahoryPdsYIU+1jwJ/2gQx/1YENC7gz3iUXgxXNChQqZ8Qapf3gVUufw
9uS2MjYRWmXAmSSLTc4nj3SX4RnZpfTaAvdgD9qh0zulIK5jySpcQzliBLPCE8Ap
WafWOY1p0mNcYUGD36GtjPO1mwyUWfVzK4VMhrqnaAA3bJ0iCiK/kqNkDjN3T7EP
xaurZCvbUwZU9p/cB4JrnLk7k959uxpBSBeTac9f057BjPFsyLAZnzmlIfA1XLq4
VtKL5qvnay1deRYpZXFeK4QDASymKro9+QY6MV2l9/TSoynu/jYIeIFGVXkD3kLU
KtI2eKxHduseT49Ax9yZMzmqYUI0uCtSJvX2eRC/pifPQDChkpjDQBp4ryLfOAlH
eouLE9mtWMVJKvBykCaYK5zzJFqbF6atPsZ6/+Nwgur52pRFI6yrE+t06BzkBkcS
u0SwW1IqAVctLViiq97o6VvYj3nxC0/EXn8OTyFx13nW/HKa9I5m5UO+wzNJl15Y
0Lk48RPVWmpBwPkcAWMtGc3TDCik3FF3BziSYGdtkUwPtO0TuXOzS5Ats7kCDQRT
OyaaARAAvG+PmIRpCu8qls1lzJN6CR1jfMGFPBpG1EZ+do4NcrmEuHCTh/Qt0/4i
gDLFGBiIyCQ9/OBUF/lf7ziRFqN9mztC+OCx4ULWUsTtu2aZuHaeIxlStL0Eze8N
KL/BL3u9PJ0SvvbhztEvGOv+hMdYgRH1PuLPLzizIOo1vg+a31P8vzuohW2QyVlw
61S5hDOclYkDUfPxKQ+u0/fvMAUXBAccGus3ns4d2PaeBjqiuSS8MfCw66/5j34D
qS5avJfsiR0h1c+WaCS8GPExOPiviO1qrTXLhJw6kh6zqHIoSMBcnGOUafU2vj5I
0D7LMpjHwCEIWgceOUmRsE8m6eBge49qENdXVGELQgVfvHgfFEEKKORKHGX7khLx
VPZL3ZhQreEPLXm73hpvjB7uBUBKMaaZYOHothfPdUd/JXRt1ZQ24zCSdqGpJ7x1
rIJWWVo9EM7Qq0wtvu3g6tvLPf8yoOBcQ7Bvi3BYYOKpAAZEGad7N971pMVjeVYJ
vLb1595nImwbdO42YUT4wV0oxyUTtx2MSRr1ptvviXNQrkCo74Q0dCM0w/lwR2IO
Go5mHKSLBlxkBjTh01n6Iv9ACWGAqpwJvtZKlB7Lm9gzXHFM2WPPJ9y0npRDGS2I
jtUvshrW7XtiwjtM5iEBeCTslhZHzpgBDv0PUGHUy9+OHtx9LlUAEQEAAYkERAQY
AQoADwUCUzsmmgIbLgUJEswDAAIpCRAJ/kRzTreZDsFdIAQZAQoABgUCUzsmmgAK
CRBF9e69gT2ujoIzD/9ZXbiKvsx2DBFgX3QXjrMWT1XPc7dv1x4IW25b7CWq0OG5
WrDIgJCbuUfp57tg7C+YFLz5jnpK5Ht8uvyKHtkgbS0tIuNaSrDm6X5qCxeRhtyQ
KKjoKSnK+Fj4GeSo/hWQ3jJ0CCDxQNF13A66Yg/yD27apa01f9GLaEUIiEjbXL6X
gLnQAwCcETkxHBWPlm1XT7P1OEjLoosWRWUi722rax55u9R4ucy3mT7Y3DDIbhnJ
5fBgUg/4xc9F2iXyJqrYmR5x9Zz45CnF1e2nwWSUSdHQlcjPbiWZrCKhODglw3Mk
0wmWP1fgNJg8TXHx2ZdtNIK3SAJoVGe+DHEaTwL8o9Hy3Zrd1ye+DWheK6KEYmzn
/+ZMFjaEkk4Sm6cX3Zha83z7wUtT+jLRinyf2wquwVGdcJw8MUkNhv19VPbFtm+V
ziV+fbiOimcuKsq6eF1jUiXSosOKh6stc/+h+J5P00C0OSy+Ku7w9BZ3aTe3iugy
GWKHpAtQAt4l07ChUyKodPboaSMXiI+XP5co0KZt7FghKC7Bn1ttJDj70IgbqNuu
iDwhaHhGYBxw90RpgdXO3+wbtg7B2OUmBmLzTJVNWI7vqMzIvaJy0ZCwShNSCYT1
FZk0k/AsOixe5Gbhhi7o8DCoAZC1nM+xHYr04613NlPs52bqVk8c5TO+otNgD7UN
EACQdyGa+slpdHMLVrdubatBVJarH3Wd0vUH3Ba5Ir9NjSEpiijRoQefbH1wSUV0
/AtQY2LwOzhufFGK5xNrOVPoPTbKXN1fUwCktsaEGDrv2Rpr/TiYuqOsAE26UefK
7yvKab9nEVbBPq6IQRl8pSEqmxbKD9zBbpI6+2WLMW+PnJPWz5f2g3PxdtFpfeVe
q0o22+L6sdGHH8QuQq/6od7fSB1tvHxzPXsuw7MvULRoGnqh2f336DzMohBbfs2r
iI+Ik667uOF4RrLNRfDVRb5PiDcTAuHGaDtJjUpBlrG9WNZlwjo9k3WhUWFPha4Z
KiRIGvTh+C4wJmJeR51u41OlQjEF4MJTgZiGWZSnTKbv942FvXQpKz5Dgt6NaGDc
xEXOj5ohP8VWlLZel8H8ncoljNEcT2y+SU3C8o3q0xzv6jTlZR/pi15ExkZ4mf7V
QdPkLwUrwp10HMRt8pxCBjTnvEBwMVLyq1fo5z3czv3LiWW8RBYtTBZ/sFv2xRca
rfdVeGY5r7ZKRhlkJj6L8x96Xik7D5b9G5SiIEi6XX3ZOIaiV4mDfDaVFuIInPdr
U0Bg1jqBWQZDqjEvfRHYIDQpd3Ahxbv56J02tl6s29gMT5dYRFE7OhaJ0CCphsH6
6qcPvWImsyQ3OdVJ7AU3fuFRFVIgQwoohTpKKCIGTJ8u1g==
=sN90
-----END PGP PUBLIC KEY BLOCK-----

@rvagg
Copy link
Member

rvagg commented Apr 4, 2015

not yet, is that the same one you have the fingerprint for on this PR?

@rvagg
Copy link
Member

rvagg commented Apr 4, 2015

ah, wait, sorry:

$ gpg --keyserver pool.sks-keyservers.net --recv-keys FD3A5288F042B6850C66B31F09FE44734EB7990E
gpg: requesting key 4EB7990E from hkp server pool.sks-keyservers.net
gpg: key 4EB7990E: public key "keybase.io/fishrock <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)

@rvagg
Copy link
Member

rvagg commented Apr 4, 2015

lgtm! let's do this!

@Fishrock123
Copy link
Contributor Author

https://github.com/iojs/io.js/blob/v1.x/tools/release.sh#L53

Ah looks like it just searches it.

@Fishrock123
doc: better formatting for collaborator GPG keys
ccbea18 
PR-URL: nodejs#1324
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@Fishrock123
doc: add GPG fingerprint for Fishrock123
8c6c376 
PR-URL: nodejs#1324
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@rvagg
Copy link
Member

rvagg commented Apr 4, 2015

you should be able to run that command on this branch and it won't bork now, if it works then merge this and get a release out!

@Fishrock123 Fishrock123 merged commit 8c6c376 into nodejs:v1.x Apr 4, 2015
@Fishrock123 Fishrock123 mentioned this pull request Apr 4, 2015
Closed
Starefossen pushed a commit to Starefossen/docker-iojs that referenced this pull request Apr 4, 2015
Import GPG key for Fishrock123
7235ee7 
Related: nodejs/node#1324
@Starefossen Starefossen mentioned this pull request Apr 4, 2015
Merged
Starefossen pushed a commit to Starefossen/docker-iojs that referenced this pull request Apr 4, 2015
Import GPG key for Fishrock123
6ac7eb8 
PR-URL: nodejs#48
Related: nodejs/node#1324
Related: nodejs/node#1225
Signed-off-by: Hans Kristian Flaatten <[email protected]>
@Fishrock123 Fishrock123 deleted the fishrock-gpg-key branch May 12, 2015 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fishrock123 @benjamingr @bnoordhuis @rvagg