Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.x android #1307

Closed
wants to merge 1 commit into from
Closed

V1.x android #1307

wants to merge 1 commit into from

Conversation

Gioyik
Copy link
Contributor

@Gioyik Gioyik commented Apr 1, 2015

Those are a few changes I did to compile io.js and run it as bin file on Android and based devices.

@Fishrock123 Fishrock123 added the build Issues and PRs related to build files or the CI. label Apr 1, 2015
Be sure you have downloaded and extracted [Android NDK](https://developer.android.com/tools/sdk/ndk/index.html) before in a folder. Then run:

```sh
$ ./android-configure /path/to/you/android-ndk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path/to/your/android-ndk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to compile for Android devices you need to use the toolchain in the Android NDK for cross compiling. Inside Android NDK there is an build/tools/make-standalone-toolchain.sh script that will create an android-toolchain folder inside io.js folder with the cross binaries to use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he was pointing out the typo? /you/ -> /your/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have made that more obvious :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that has more sense now. I going to fix it. :)

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 1, 2015

Let me know if there's something that needs a change. If not I will squash the commits on this PR to merge it.

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 2, 2015

@bnoordhuis it's done! Please, check it an let me know if everything is ok.

(https://developer.android.com/tools/sdk/ndk/index.html)
before in a folder. Then run:

```sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the sh please, we're showing these shell examples without that formatting because it makes little sense and isn't consistent when you're not showing bash anyway (plus, $ isn't a bashism as it's used here)

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 2, 2015

@rvagg it's done

@rvagg
Copy link
Member

rvagg commented Apr 2, 2015

lgtm with one question

@Gioyik
Copy link
Contributor Author

Gioyik commented Apr 2, 2015

Answered question @rvagg

bnoordhuis pushed a commit that referenced this pull request Apr 3, 2015
Also add Android build instructions to the README.

PR-URL: #1307
Reviewed-By: Ben Noordhuis <[email protected]>
@bnoordhuis
Copy link
Member

Thanks, landed with a reworded commit log in 65d4d25. I also backed out the ARMv6 changes FWIW.

@bnoordhuis bnoordhuis closed this Apr 3, 2015
Fishrock123 added a commit that referenced this pull request Apr 6, 2015
Notable changes:

* npm: upgrade npm to 2.7.5. See the npm CHANGELOG.md for details.
Includes two important security fixes.
https://github.com/npm/npm/blob/master/CHANGELOG.md#v275-2015-03-26
* openssl: preliminary work has been done for an upcoming upgrade to
OpenSSL 1.0.2a #1325 (Shigeki Ohtsu). See #589 for additional details.
* timers: a minor memory leak when timers are unreferenced was fixed,
alongside some related timers issues #1330 (Fedor Indutny). This
appears to have fixed the remaining leak reported in #1075.
* android: it is now possible to compile io.js for Android and related
devices #1307 (Giovanny Andres Gongora Granada).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants