Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document repl on-demand loading #1249

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

Continuation of #1248. Related: #992.

@Fishrock123 : Updated, please check again

@silverwind silverwind added the doc Issues and PRs related to the documentations. label Mar 24, 2015
@@ -166,6 +166,9 @@ Example of listening for `reset`:
Inside the REPL, Control+D will exit. Multi-line expressions can be input.
Tab completion is supported for both global and local variables.

Core modules will be on-demand loaded into the environment. For example,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just swap loaded and on-demand :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "loaded on-demand" would sound better here. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, didn't even realize @Fishrock123 beat me to it :)

@Fishrock123
Copy link
Contributor

LGTM with nit

@silverwind silverwind changed the title doc: document repl auto-loading doc: document repl on-demand loading Mar 24, 2015
@brendanashworth
Copy link
Contributor

LGTM too.

@silverwind silverwind self-assigned this Mar 24, 2015
silverwind added a commit that referenced this pull request Mar 24, 2015
Fixes: #992
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Brendan Ashworth <[email protected]>
PR-URL: #1249
@silverwind
Copy link
Contributor Author

merged in e84dd5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants