node: ensure that streams2 won't .end() stdin
#1233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stdin is purely read-only stream. Although, `net.Socket` might be used to create it if stdin is in fact a Pipe or TCP socket, the `stream.Duplex` should not try to call `.end()` on it. Fix: nodejs#1068
|
CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/359/ . I hope it'll help :) |
|
Yay, build appears to be green (except one spurious failure)! |
| @@ -1 +1,2 @@ | |||
| debugger; | |||
| @@ -630,6 +630,8 @@ | |||
| writable: false | |||
| }); | |||
| } | |||
| // Ensure that Streams2 won't try to `.end()` the stream | |||
There was a problem hiding this comment.
nit: might rephrase this comment to make sure that stdin can't be .end()-ed, since we're on streams3 now.
|
LGTM other than comment nit (which can be ignored if desired.) |
indutny
added a commit
that referenced
this pull request
Mar 22, 2015
Stdin is purely read-only stream. Although, `net.Socket` might be used to create it if stdin is in fact a Pipe or TCP socket, the `stream.Duplex` should not try to call `.end()` on it. Fix: #1068 PR-URL: #1233 Reviewed-By: Chris Dickinson <[email protected]>
|
Thank you, landed in 9ae1a61 ! |
|
I don't think this is a good fix. |
|
@bnoordhuis not really, it means the same thing as it was before this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stdin is purely read-only stream. Although,
net.Socketmight be usedto create it if stdin is in fact a Pipe or TCP socket, the
stream.Duplexshould not try to call.end()on it.Fix: #1068
cc @rvagg