src: don't error at startup when cwd doesn't exist #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Looks like you can't rmdir the cwd on Windows, I'll update the tests. It seems I broke parallel/test-process-argv-0 on Windows. I'll look into that, I anticipated breakage of that nature. Anyone know what's up with Solaris? The rmdir calls are failing with EINVAL. /cc @iojs/platform-solaris |
|
The problem on Solaris/Illumos is that you can't remove a directory you're currently standing in. Manpage here: https://smartos.org/man/2/rmdir. |
bnoordhuis
force-pushed
the
fix-issue-1184
branch
from
6e15fe0
to
daa3221
Compare
|
It seems I accidentally - or let's say: coincidentally - fixed an ancient Windows bug where process.argv[0] wasn't properly expanded. New CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/330/ |
|
LGTM after fix. Bonus points for tap output |
The current working directory may not exist when iojs starts up. Don't treat that as an error because it's still possible to do many useful things, like evaluating a command line script or starting a REPL. This commit also fixes an age-old Windows bug where process.argv[0] was not properly expanded, that's why the parallel/test-process-argv-0 test gets an update as well. Fixes: nodejs#1184 PR-URL: nodejs#1194 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
The current working directory may not exist when the REPL starts up. Don't treat that as an error because it's still possible to do many useful things. This is like the previous commit but for the REPL. Fixes: nodejs#1184 PR-URL: nodejs#1194 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
bnoordhuis
force-pushed
the
fix-issue-1184
branch
from
daa3221
to
2b2e48a
Compare
This was referenced Apr 24, 2023
This was referenced Apr 26, 2023
This was referenced Apr 27, 2023
This was referenced Jul 8, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current working directory may not exist when iojs starts up. Don't
treat that as an error because it's still possible to do many useful
things, like evaluating a command line script or starting a REPL.
Fixes: #1184
R=@mscdex?
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/326/