Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 2.7.0 #1080

Closed
wants to merge 2 commits into from
Closed

deps: upgrade npm to 2.7.0 #1080

wants to merge 2 commits into from

Conversation

othiym23
Copy link
Contributor

@othiym23 othiym23 commented Mar 6, 2015

This was actually a pretty significant release for a number of reasons, because I tried to merge or otherwise resolve as many of npm's outstanding pull requests as I could. The CHANGELOG.md has the full details, but here are the bits most pertinent to io.js:

  • 145af65
    #4887 Replace calls to the
    node-gyp script bundled with npm by passing the
    --node-gyp=/path/to/node-gyp option to npm. Swap in pangyp or a version
    of node-gyp modified to work better with io.js without having to touch
    npm's code! (@ackalker)
  • 2f6a1df
    #1999 Only run stop and start
    scripts (plus their pre- and post- scripts) when there's no restart script
    defined. This makes it easier to support graceful restarts of services
    managed by npm. (@watilde /
    @scien)
  • 448efd0
    #2853 Add support for --dev and
    --prod to npm ls, so that you can list only the trees of production or
    development dependencies, as desired.
    (@watilde)
  • a0a8777
    #7463 Split the list printed by
    npm run-script into lifecycle scripts and scripts directly invoked via npm run-script. (@watilde)
  • a5edc17
    #6749 [email protected]:
    Support for passing scopes to npm init so packages are initialized as part
    of that scope / organization / team. (@watilde)

Includes a cherry-picked version of @cjihrig's combined node-gyp patch. It would be really great to get rid of the need for that patch sooooon.
The 3 features at the end are what caused the semver-minor bump, but do read the full CHANGELOG for a lengthy discussion of why the second change might be considered a breaking change, but isn't in fact. Semver can be pretty nuanced.

othiym23 and others added 2 commits March 6, 2015 03:00
Every npm version bump requires a few patches to be floated on
node-gyp for io.js compatibility. These patches are found in
03d1992,
5de334c, and
da730c7. This commit squashes
them into a single commit.

PR-URL: nodejs#990
Reviewed-By: Ben Noordhuis <[email protected]>
@othiym23 othiym23 changed the title deps: upgrade to 2.7.0 deps: upgrade npm to 2.7.0 Mar 6, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Mar 6, 2015

LGTM. make test and make test-npm passed for me locally. Is anyone opposed to landing this due to the potential breaking change mentioned above?

@Fishrock123
Copy link
Contributor

Considering discussion in #942, I'd say land it.

Personally, I'm not really sure what to test for landing npm bumps.

cjihrig pushed a commit that referenced this pull request Mar 6, 2015
PR-URL: #1080
Reviewed-By: Colin Ihrig <[email protected]>
@cjihrig
Copy link
Contributor

cjihrig commented Mar 6, 2015

Thanks! Landed in fe14802 and dee07e2.

@cjihrig cjihrig closed this Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants