Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add basic mips/mipsel support #1045

Merged
merged 1 commit into from
Mar 5, 2015

Conversation

bnoordhuis
Copy link
Member

Extend the configure script so that it knows how to generate build files
for mips and mipsel. Actually building io.js is pending MIPS buildbots.

R=@rvagg?

Not sure if useful but at least people can report build errors now.

@rvagg
Copy link
Member

rvagg commented Mar 3, 2015

what are your defaults based on for the --with options?

LGTM I suppose, I don't really want to give the impression we support this or are necessarily even planning on supporting it so "Valid values are" concerns me a little but I guess it'll be interesting to see what bug reports we get (if any).

@bnoordhuis
Copy link
Member Author

what are your defaults based on for the --with options?

They're V8's defaults when you build it standalone.

@rvagg
Copy link
Member

rvagg commented Mar 4, 2015

k, 👍 then

@bnoordhuis
Copy link
Member Author

@jdub I pushed what is hopefully a fix. Can you give it another try?

@jdub
Copy link

jdub commented Mar 4, 2015

The kernel still kicks up a stink. OpenWrt is specifically built without kernel FPU emu support, so this is what happens when software isn't built with soft-float (or sneaks in hard-float regardless, which is what I suspect V8 is doing):

FPU emulator disabled, make sure your toolchain was compiled with software floating point support (soft-float)

^CFloating point exception

@bnoordhuis
Copy link
Member Author

Right, you almost certainly need a kernel with FPU emulation because I don't think V8 knows how to emit calls to the helpers in libgcc_s.so. Might make for an interesting side project. I'm going to land this PR and we can reiterate on it more.

Extend the configure script so that it knows how to generate build files
for mips and mipsel.  Actually building io.js is pending MIPS buildbots.

PR-URL: nodejs#1045
Reviewed-By: Rod Vagg <[email protected]>
@bnoordhuis bnoordhuis merged commit 726671c into nodejs:v1.x Mar 5, 2015
@bnoordhuis bnoordhuis deleted the basic-mips-build branch March 5, 2015 18:52
@rvagg rvagg mentioned this pull request Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants