src: do not leak handles on debug and exit

Ensure HandleScope is created before creating any new handles (which `Context::Scope` and `Environment::GetCurrent` does). PR-URL: #1133 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Brian White <[email protected]>
nodejs · Mar 12, 2015 · e2c9040 · e2c9040
1 parent 8c4f0df
commit e2c9040
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/node.cc b/src/node.cc
@@ -3195,6 +3195,7 @@ static void DispatchDebugMessagesAsyncCallback(uv_async_t* handle) {
   if (debugger_running == false) {
     fprintf(stderr, "Starting debugger agent.\n");
 
+    HandleScope scope(node_isolate);
     Environment* env = Environment::GetCurrent(node_isolate);
     Context::Scope context_scope(env->context());
 
@@ -3603,8 +3604,8 @@ void AtExit(void (*cb)(void* arg), void* arg) {
 
 
 void EmitBeforeExit(Environment* env) {
-  Context::Scope context_scope(env->context());
   HandleScope handle_scope(env->isolate());
+  Context::Scope context_scope(env->context());
   Local<Object> process_object = env->process_object();
   Local<String> exit_code = FIXED_ONE_BYTE_STRING(env->isolate(), "exitCode");
   Local<Value> args[] = {