net: fix error details in connect()

3ac4941 introduced a bug as it attempted to access properties of an undefined variable. This commit cleans up the offending code. Fixes: #510 PR-URL: #514 Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Jan 19, 2015 · e2558f0 · e2558f0
1 parent 4af5746
commit e2558f0
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -813,13 +813,13 @@ function connect(self, address, port, addressType, localAddress, localPort) {
   }
 
   if (err) {
-    self._getsockname();
+    var sockname = self._getsockname();
     var details;
-    if (self._sockname) {
-      ex.localAddress = self._sockname.address;
-      ex.localPort = self._sockname.port;
-      details = ex.localAddress + ':' + ex.localPort;
+
+    if (sockname) {
+      details = sockname.address + ':' + sockname.port;
     }
+
     var ex = exceptionWithHostPort(err, 'connect', address, port, details);
     self._destroy(ex);
   }