js_stream: fix leak of instances

Don't forget to call `MakeWeak` to ensure that instance objects are garbage collectable. PR-URL: #1078 Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Mar 6, 2015 · dccb69a · dccb69a
1 parent 583a868
commit dccb69a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/js_stream.cc b/src/js_stream.cc
@@ -26,6 +26,7 @@ JSStream::JSStream(Environment* env, Handle<Object> obj, AsyncWrap* parent)
     : StreamBase(env),
       AsyncWrap(env, obj, AsyncWrap::PROVIDER_JSSTREAM, parent) {
   node::Wrap(obj, this);
+  MakeWeak<JSStream>(this);
 }
 
 

diff --git a/src/js_stream.h b/src/js_stream.h
@@ -14,6 +14,8 @@ class JSStream : public StreamBase, public AsyncWrap {
                          v8::Handle<v8::Value> unused,
                          v8::Handle<v8::Context> context);
 
+  ~JSStream();
+
   void* Cast() override;
   bool IsAlive() override;
   bool IsClosing() override;
@@ -28,7 +30,6 @@ class JSStream : public StreamBase, public AsyncWrap {
 
  protected:
   JSStream(Environment* env, v8::Handle<v8::Object> obj, AsyncWrap* parent);
-  ~JSStream();
 
   AsyncWrap* GetAsyncWrap() override;