querystring: parse numbers correctly

Fixes a number parsing regression introduced in 85a92a3 Fixes: #1208 PR-URL: #1213 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Brian White <[email protected]>
nodejs · Mar 20, 2015 · a89f5c2 · a89f5c2
1 parent 8de78e4
commit a89f5c2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/querystring.js b/lib/querystring.js
@@ -90,6 +90,9 @@ var hexTable = new Array(256);
 for (var i = 0; i < 256; ++i)
   hexTable[i] = '%' + ((i < 16 ? '0' : '') + i.toString(16)).toUpperCase();
 QueryString.escape = function(str) {
+  // replaces encodeURIComponent
+  // http://www.ecma-international.org/ecma-262/5.1/#sec-15.1.3.4
+  str = '' + str;
   var len = str.length;
   var out = '';
   var i, c;

diff --git a/test/parallel/test-querystring.js b/test/parallel/test-querystring.js
@@ -138,6 +138,14 @@ qsWeirdObjects.forEach(function(testCase) {
   assert.equal(testCase[1], qs.stringify(testCase[0]));
 });
 
+// coerce numbers to string
+assert.strictEqual('foo=0', qs.stringify({ foo: 0 }));
+assert.strictEqual('foo=0', qs.stringify({ foo: -0 }));
+assert.strictEqual('foo=3', qs.stringify({ foo: 3 }));
+assert.strictEqual('foo=-72.42', qs.stringify({ foo: -72.42 }));
+assert.strictEqual('foo=', qs.stringify({ foo: NaN }));
+assert.strictEqual('foo=', qs.stringify({ foo: Infinity }));
+
 // nested
 var f = qs.stringify({
   a: 'b',