net: check close callback is function

PR-URL: #609 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
nodejs · Feb 2, 2015 · 8c0742f · 8c0742f
1 parent 207e48c
commit 8c0742f
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/net.js b/lib/net.js
@@ -1368,7 +1368,7 @@ Server.prototype.close = function(cb) {
     self._emitCloseIfDrained();
   }
 
-  if (cb) {
+  if (typeof cb === 'function') {
     if (!this._handle) {
       this.once('close', function() {
         cb(new Error('Not running'));

diff --git a/test/parallel/test-net-listen-close-server-callback-is-not-function.js b/test/parallel/test-net-listen-close-server-callback-is-not-function.js
@@ -0,0 +1,20 @@
+var assert = require('assert');
+var common = require('../common');
+var net = require('net');
+
+var server = net.createServer(assert.fail);
+var closeEvents = 0;
+
+server.on('close', function() {
+  ++closeEvents;
+});
+
+server.listen(common.PORT, function() {
+  assert(false);
+});
+
+server.close('bad argument');
+
+process.on('exit', function() {
+  assert.equal(closeEvents, 1);
+});