module: remove '' from Module.globalPaths

If `$NODE_PATH` contains trailing separators, `Module.globalPaths` will contains empty strings. When `Module` try to resolve a module's path, `path.resolve('', 'index.js')` will boil down to `$PWD/index.js`, which makes sub modules can access global modules and get unexpected result. PR-URL: #1488 Reviewed-By: Roman Reiss <[email protected]>
nodejs · Apr 23, 2015 · 7384ca8 · 7384ca8
1 parent a7d7463
commit 7384ca8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/module.js b/lib/module.js
@@ -489,7 +489,9 @@ Module._initPaths = function() {
 
   var nodePath = process.env['NODE_PATH'];
   if (nodePath) {
-    paths = nodePath.split(path.delimiter).concat(paths);
+    paths = nodePath.split(path.delimiter).filter(function(path) {
+      return !!path;
+    }).concat(paths);
   }
 
   modulePaths = paths;

diff --git a/test/parallel/test-module-globalpaths-nodepath.js b/test/parallel/test-module-globalpaths-nodepath.js
@@ -6,20 +6,22 @@ var module = require('module');
 var isWindows = process.platform === 'win32';
 
 var partA, partB;
+var partC = '';
 
 if (isWindows) {
   partA = 'C:\\Users\\Rocko Artischocko\\AppData\\Roaming\\npm';
   partB = 'C:\\Program Files (x86)\\nodejs\\';
-  process.env['NODE_PATH'] = partA + ';' + partB;
+  process.env['NODE_PATH'] = partA + ';' + partB + ';' + partC;
 } else {
   partA = '/usr/test/lib/node_modules';
   partB = '/usr/test/lib/node';
-  process.env['NODE_PATH'] = partA + ':' + partB;
+  process.env['NODE_PATH'] = partA + ':' + partB + ':' + partC;
 }
 
 module._initPaths();
 
 assert.ok(module.globalPaths.indexOf(partA) !== -1);
 assert.ok(module.globalPaths.indexOf(partB) !== -1);
+assert.ok(module.globalPaths.indexOf(partC) === -1);
 
-assert.ok(Array.isArray(module.globalPaths));
+assert.ok(Array.isArray(module.globalPaths));