Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
buffer: fast-case for empty string in byteLength
When the string is empty, calling the binding is unnecessary and slow. PR-URL: #1441 Reviewed-by: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Christian Tellnes <[email protected]>
- Loading branch information
431673e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg
changelog-maker
is ok withReviewed-by
right? Dx431673e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's an
i
regex match, but it's not actually used in the changelog anyway so whatever