src: use Number::New() for heapTotal/heapUsed

With --max_old_space_size=12345 it's possible to create a JS heap that is larger than what fits in an unsigned int so use Number::New() rather than Integer::NewFromUnsigned(). Performance-wise, it doesn't matter much. If V8 can fit the double in a SMI, it will. PR-URL: #1148 Reviewed-By: Trevor Norris <[email protected]>
nodejs · Mar 16, 2015 · 2551c1d · 2551c1d
1 parent 4f39499
commit 2551c1d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -1932,10 +1932,10 @@ void MemoryUsage(const FunctionCallbackInfo<Value>& args) {
   HeapStatistics v8_heap_stats;
   env->isolate()->GetHeapStatistics(&v8_heap_stats);
 
-  Local<Integer> heap_total =
-      Integer::NewFromUnsigned(env->isolate(), v8_heap_stats.total_heap_size());
-  Local<Integer> heap_used =
-      Integer::NewFromUnsigned(env->isolate(), v8_heap_stats.used_heap_size());
+  Local<Number> heap_total =
+      Number::New(env->isolate(), v8_heap_stats.total_heap_size());
+  Local<Number> heap_used =
+      Number::New(env->isolate(), v8_heap_stats.used_heap_size());
 
   Local<Object> info = Object::New(env->isolate());
   info->Set(env->rss_string(), Number::New(env->isolate(), rss));