tls: destroy singleUse context immediately

Destroy singleUse context right after it is going out of use. Fix: #1522 PR-URL: #1529 Reviewed-By: Shigeki Ohtsu <[email protected]>
nodejs · Apr 30, 2015 · 1787416 · 1787416
1 parent 2684c90
commit 1787416
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
@@ -134,8 +134,10 @@ exports.createSecureContext = function createSecureContext(options, context) {
   }
 
   // Do not keep read/write buffers in free list
-  if (options.singleUse)
+  if (options.singleUse) {
+    c.singleUse = true;
     c.context.setFreeListLength(0);
+  }
 
   return c;
 };

diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -301,7 +301,9 @@ TLSSocket.prototype._wrapHandle = function(handle) {
 };
 
 TLSSocket.prototype._destroySSL = function _destroySSL() {
-  return this.ssl.destroySSL();
+  this.ssl.destroySSL();
+  if (this.ssl._secureContext.singleUse)
+    this.ssl._secureContext.context.close();
 };
 
 TLSSocket.prototype._init = function(socket, wrap) {