buffer: align chunks on 8-byte boundary

When slicing global pool - ensure that the underlying buffer's data ptr is 8-byte alignment to do not ruin expectations of 3rd party C++ addons. NOTE: 0.10 node.js always returned aligned pointers and io.js should do this too for compatibility. PR-URL: #1126 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-by: Bert Belder <[email protected]>
nodejs · Mar 11, 2015 · 07c0667 · 07c0667
1 parent d33a647
commit 07c0667
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -157,6 +157,12 @@ function palloc(that, length) {
   var buf = sliceOnto(allocPool, that, start, end);
   poolOffset = end;
 
+  // Ensure aligned slices
+  if (poolOffset & 0x7) {
+    poolOffset |= 0x7;
+    poolOffset++;
+  }
+
   return buf;
 }