fs: add error code on null byte paths

This commit adds a code field to the error returned by nullCheck(). Fixes: #517 PR-URL: #519 Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Jan 19, 2015 · 03ee4d8 · 03ee4d8
1 parent e2558f0
commit 03ee4d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -86,6 +86,7 @@ function assertEncoding(encoding) {
 function nullCheck(path, callback) {
   if (('' + path).indexOf('\u0000') !== -1) {
     var er = new Error('Path must be a string without null bytes.');
+    er.code = 'ENOENT';
     if (!callback)
       throw er;
     process.nextTick(function() {

diff --git a/test/parallel/test-fs-null-bytes.js b/test/parallel/test-fs-null-bytes.js
@@ -7,6 +7,7 @@ function check(async, sync) {
   var argsSync = Array.prototype.slice.call(arguments, 2);
   var argsAsync = argsSync.concat(function(er) {
     assert(er && er.message.match(expected));
+    assert.equal(er.code, 'ENOENT');
   });
 
   if (sync)